fix: sd-datepicker css properties not showing in storybook#3058
fix: sd-datepicker css properties not showing in storybook#3058martascorreia wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: a5a4d49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Storybook has been deployed for branch |
|
Hi @martascorreia for sd-datepicker, this is fine now but I checked all the components and noticed there is no css property for the following components, let me know if they're not supposed to have;
Also for the sd-expandable, this error is being returned |
Hey @tega-ekakitie, Example of sd-checkbox-group, that doesn't have any css properties: As for the sd-expandable issue, could you check again, I can't seem to reproduce it. Does it appear as soon as you enter the "Docs" page? |
|
@martascorreia looks good to me |




Description:
closes: #3053
The issue is that the JSDoc comments (@summary, @dependency, @dependency, @cssproperty, etc) are the documentation for the @CustomElement, and therefore have to be immediately before this element.
For the fix, I could've moved the converter classes to before the JSDocs, but for readability and maintainability, I created a new file. Let me know if this is the best approach or if you rather have them at the top. They have to be put before the @CustomElement, otherwise it can't read them.
Definition of Reviewable: